Fix KeyError Bug to support in SGLang

#13

Trying to support this in SGLang. Need this approved to merge the another PR into SGLang (https://github.com/sgl-project/sglang/pull/13166)

Arguments that are not passed in kwargs are being popped, resulting in KeyError.

The _further_process_kwargs function includes the 'interpolation instead of resample' now.

We encountered a similar issue when enabling eagle support for VLLM? Is this primarily a compatibility problem stemming from Hugging Face?

Yeah, it is.

The Eagle2.5 Github repo requires transformers==4.51.0, but SGLang requires transformers==4.57.1. In transformers >=4.56.0, a commit was included that broke image_processing_eagle2_5_vl_fast.py due to these lines that I am fixing in this PR. This is the commit: https://github.com/huggingface/transformers/commit/f690a2a1e09e8a8c7b04cc050ef24838c609060b.

I updated my PR to be backwards-compatible, so you don't have to update the Eagle2.5 Github repo, but SGLang and vLLM can use a newer version of HF Transformers.

IC. Thanks for your support! @jonahbernard

Zhiding changed pull request status to merged

Sign up or log in to comment