updating feedback section

added more feedback parameters.
made functions for all the work with feedback.

app.py

@@ -30,11 +30,15 @@ import uuid
 import time
 import asyncio
 import aiohttp
+from datetime import datetime
+import base64
+from io import BytesIO
 # '-----------------'
 import smtplib
 from email.mime.multipart import MIMEMultipart
 from email.mime.text import MIMEText 
 from email.mime.base import MIMEBase
+from email.mime.application import MIMEApplication
 from email import encoders
 # '------------------'
 print("***************************************************************")
@@ -81,6 +85,7 @@ def get_state(session_id):
 def set_state(session_id, key, value):
     st.session_state.session_states[session_id][key] = value
 
+
 @st.cache_resource
 def load_model(modelname):
     model_name = modelname
@@ -114,6 +119,8 @@ nlp, s2v = load_nlp_models()
 similarity_model, spell = load_qa_models()
 context_model = similarity_model
 model, tokenizer = load_model(modelname)
+
+
 # Info Section
 def display_info():
     st.sidebar.title("Information")
@@ -154,7 +161,7 @@ def get_pdf_text(pdf_file):
         text += page.get_text()
     return text
 
-def save_feedback(question, answer, rating, options, context):
+def save_feedback_og(question, answer, rating, options, context):
     feedback_file = 'question_feedback.json'
     if os.path.exists(feedback_file):
         with open(feedback_file, 'r') as f:
@@ -175,34 +182,117 @@ def save_feedback(question, answer, rating, options, context):
         json.dump(feedback_data, f)
     
     return feedback_file
+
 # -----------------------------------------------------------------------------------------
-def send_email_with_attachment(email_subject, email_body, recipient_emails, sender_email, sender_password, attachment_path):
-    msg = MIMEMultipart()
-    msg['From'] = sender_email
-    msg['To'] = ", ".join(recipient_emails)  # Join the list of recipients with commas
-
-    msg['Subject'] = email_subject
-
-    msg.attach(MIMEText(email_body, 'plain'))
-
-    attachment = open(attachment_path, 'rb')
-    part = MIMEBase('application', 'octet-stream')
-    part.set_payload(attachment.read()) 
-    encoders.encode_base64(part)
-    part.add_header('Content-Disposition', f'attachment; filename={os.path.basename(attachment_path)}')
-
-    msg.attach(part)
-    attachment.close()
-
-    with smtplib.SMTP('smtp.gmail.com', 587) as server:
-        server.starttls()
-        print(sender_email)
-        print(sender_password)
-        server.login(sender_email, sender_password)
-        text = msg.as_string()
-        server.sendmail(sender_email, recipient_emails, text)
+def send_email_with_attachment(email_subject, email_body, recipient_emails, sender_email, sender_password, attachment):
+    smtp_server = "smtp.gmail.com"  # Replace with your SMTP server
+    smtp_port = 587  # Replace with your SMTP port
+
+    # Create the email message
+    message = MIMEMultipart()
+    message['From'] = sender_email
+    message['To'] = ", ".join(recipient_emails) 
+    message['Subject'] = email_subject
+    message.attach(MIMEText(email_body, 'plain'))
+
+    # Attach the feedback data if available
+    if attachment:
+        attachment_part = MIMEApplication(attachment.getvalue(), Name="feedback_data.json")
+        attachment_part['Content-Disposition'] = f'attachment; filename="feedback_data.json"'
+        message.attach(attachment_part)
+
+    # Send the email
+    try:
+        with smtplib.SMTP(smtp_server, smtp_port) as server:
+            server.starttls()
+            print(sender_email)
+            print(sender_password)
+            server.login(sender_email, sender_password)
+            text = message.as_string()
+            server.sendmail(sender_email, recipient_emails, text)
+        return True
+    except Exception as e:
+        st.error(f"Failed to send email: {str(e)}")
+        return False
 # ----------------------------------------------------------------------------------
 
+def collect_feedback(i,question, answer, context, options):
+    st.write("Please provide feedback for this question:")
+    edited_question = st.text_input("Enter improved question",value=question,key=f'fdx1{i}')
+    clarity = st.slider("Clarity", 1, 5, 3, help="1 = Very unclear, 5 = Very clear",key=f'fdx2{i}')
+    difficulty = st.slider("Difficulty", 1, 5, 3, help="1 = Very easy, 5 = Very difficult",key=f'fdx3{i}')
+    relevance = st.slider("Relevance", 1, 5, 3, help="1 = Not relevant, 5 = Highly relevant",key=f'fdx4{i}')
+    option_quality = st.slider("Quality of Options", 1, 5, 3, help="1 = Poor options, 5 = Excellent options",key=f'fdx5{i}')
+    overall_rating = st.slider("Overall Rating", 1, 5, 3, help="1 = Poor, 5 = Excellent",key=f'fdx6{i}')
+    comments = st.text_input("Additional Comments", "",key=f'fdx7{i}')
+
+    if st.button("Submit Feedback",key=f'fdx8{i}'):
+        feedback = {
+            "question": question,
+            'edited_question':edited_question,
+            "answer": answer,
+            "options": options,
+            "clarity": clarity,
+            "difficulty": difficulty,
+            "relevance": relevance,
+            "option_quality": option_quality,
+            "overall_rating": overall_rating,
+            "comments": comments
+        }
+        save_feedback(feedback)
+        st.success("Thank you for your feedback!")
+
+def save_feedback(feedback):
+    st.session_state.feedback_data.append(feedback)
+
+def analyze_feedback():
+    if not st.session_state.feedback_data:
+        st.warning("No feedback data available yet.")
+        return
+
+    df = pd.DataFrame(st.session_state.feedback_data)
+    
+    st.write("Feedback Analysis")
+    st.write(f"Total feedback collected: {len(df)}")
+    
+    metrics = ['clarity', 'difficulty', 'relevance', 'option_quality', 'overall_rating']
+    
+    for metric in metrics:
+        fig, ax = plt.subplots()
+        df[metric].value_counts().sort_index().plot(kind='bar', ax=ax)
+        plt.title(f"Distribution of {metric.capitalize()} Ratings")
+        plt.xlabel("Rating")
+        plt.ylabel("Count")
+        st.pyplot(fig)
+
+    st.write("Average Ratings:")
+    st.write(df[metrics].mean())
+
+    # Word cloud of comments
+    comments = " ".join(df['comments'])
+    if len(comments) > 1:
+        wordcloud = WordCloud(width=800, height=400, background_color='white').generate(comments)
+        fig, ax = plt.subplots()
+        plt.imshow(wordcloud, interpolation='bilinear')
+        plt.axis("off")
+        st.pyplot(fig)
+
+
+def export_feedback_data():
+    if not st.session_state.feedback_data:
+        st.warning("No feedback data available.")
+        return None
+
+    # Convert feedback data to JSON
+    json_data = json.dumps(st.session_state.feedback_data, indent=2)
+    
+    # Create a BytesIO object
+    buffer = BytesIO()
+    buffer.write(json_data.encode())
+    buffer.seek(0)
+    
+    return buffer
+
 # Function to clean text
 def clean_text(text):
     text = re.sub(r"[^\x00-\x7F]", " ", text)
@@ -517,6 +607,8 @@ def main():
     st.title(":blue[Question Generator System]")
     session_id = get_session_id()
     state = initialize_state(session_id)
+    if 'feedback_data' not in st.session_state:
+        st.session_state.feedback_data = []
 
     with st.sidebar:
         show_info = st.toggle('Show Info',True)
@@ -609,20 +701,13 @@ def main():
 
                 # q['context'] = st.text_area(f"Edit Context {i+1}:", value=q['context'], key=f"context_{i}")
             if enable_feedback_mode:
-                q['question'] = st.text_input(f"Edit Question {i+1}:", value=q['question'], key=f"question_{i}")
-                q['rating'] = st.select_slider(f"Rate this question (1-5)", options=[1, 2, 3, 4, 5], key=f"rating_{i}")
-                if st.button(f"Submit Feedback for Question {i+1}", key=f"submit_{i}"):
-                    feedback_file=save_feedback(q['question'], q['answer'], q['rating'], q['options'], q['context'])
-                    st.success(f"Feedback submitted for Question {i+1}")
-                    pswd = st.secrets['EMAIL_PASSWORD']
-                    send_email_with_attachment(
-    email_subject='feedback from QGen',
-    email_body='Please find the attached feedback JSON file.',
-    recipient_emails=['apjc01unique@gmail.com', 'channingfisher7@gmail.com'],
-    sender_email='apjc01unique@gmail.com',
-    sender_password=pswd,
-    attachment_path=feedback_file) 
-                    st.write("Feedback sent to admin")
+                collect_feedback(
+                    i,
+                    question = q['question'],
+                    answer = q['answer'],
+                    context = q['context'],
+                    options = q['options'],
+                )
             st.write("---")
         
             
@@ -648,33 +733,19 @@ def main():
 
     # View Feedback Statistics
     with st.expander("View Feedback Statistics"):
-        feedback_file = 'question_feedback.json'
-        if os.path.exists(feedback_file):
-            with open(feedback_file, 'r') as f:
-                feedback_data = json.load(f)
-            
-            st.subheader("Feedback Statistics")
-            
-            # Calculate average rating
-            ratings = [feedback['rating'] for feedback in feedback_data]
-            avg_rating = sum(ratings) / len(ratings) if ratings else 0
-            st.write(f"Average Question Rating: {avg_rating:.2f}")
-            
-            # Show distribution of ratings
-            rating_counts = {i: ratings.count(i) for i in range(1, 6)}
-            st.bar_chart(rating_counts)
-                    
-            # Show some highly rated questions
-            st.subheader("Highly Rated Questions")
-            sorted_feedback = sorted(feedback_data, key=lambda x: x['rating'], reverse=True)
-            top_questions = sorted_feedback[:5]
-            for feedback in top_questions:
-                st.write(f"Question: {feedback['question']}")
-                st.write(f"Answer: {feedback['answer']}")
-                st.write(f"Rating: {feedback['rating']}")
-                st.write("---")
-        else:
-            st.write("No feedback data available yet.")
+        analyze_feedback()
+        if st.button("Export Feedback"):
+            feedback_data = export_feedback_data()
+            pswd = st.secrets['EMAIL_PASSWORD']
+            send_email_with_attachment(
+                email_subject='feedback from QGen',
+                email_body='Please find the attached feedback JSON file.',
+                recipient_emails=['apjc01unique@gmail.com', 'channingfisher7@gmail.com'],
+                sender_email='apjc01unique@gmail.com',
+                sender_password=pswd,
+                attachment=feedback_data
+            ) 
+
     print("********************************************************************************")
 
 if __name__ == '__main__':