Fix quiz submission: prevent double-counting, ensure feedback visibility, prevent infinite loops

.gitignore

@@ -35,3 +35,5 @@ secrets/
 
 
 
+
+

app.py

@@ -1404,6 +1404,7 @@ with gr.Blocks(title="Gnosis Tutor") as app:
         """Handle answer submission."""
         print(f"🔍 [SUBMIT] Answer submitted - selected: {selected}, type: {type(selected)}, idx: {idx}")
         print(f"🔍 [SUBMIT] quiz_data type: {type(quiz_data)}, length: {len(quiz_data) if quiz_data else 'None'}")
+        print(f"🔍 [SUBMIT] Current score: {score}")
         
         # If quiz_data is empty or None, try to get it from user_state
         if not quiz_data or (isinstance(quiz_data, list) and len(quiz_data) == 0):
@@ -1423,7 +1424,7 @@ with gr.Blocks(title="Gnosis Tutor") as app:
                 gr.update(visible=False),
                 gr.update(value=0),
                 gr.update(value={"correct": 0, "total": 0}),
-                gr.update(value=quiz_data)
+                gr.update()  # Don't update quiz_data_state to avoid loops
             )
         
         # Check if answer was selected
@@ -1440,7 +1441,7 @@ with gr.Blocks(title="Gnosis Tutor") as app:
                 gr.update(visible=False),  # quiz_next_btn
                 gr.update(value=idx),  # current_question_idx
                 gr.update(value=score),  # quiz_score_state (don't update)
-                gr.update(value=quiz_data)  # quiz_data_state
+                gr.update()  # Don't update quiz_data_state to avoid loops
             )
         
         # Ensure idx is valid - fix the index bug
@@ -1450,12 +1451,18 @@ with gr.Blocks(title="Gnosis Tutor") as app:
         
         print(f"🔍 [SUBMIT] Processing question {idx + 1} of {len(quiz_data)}")
         q = quiz_data[idx]
+        
+        # Check if this question was already answered to prevent double-counting
+        was_answered = q.get('is_answered', False)
+        previous_correct = q.get('is_correct', False)
+        
         question_type = q.get('type', '').lower()
         correct_answer = q.get('correct_answer', '')
         is_correct = False
         user_selected_idx = None
         
         print(f"🔍 [SUBMIT] Question type: {question_type}, correct_answer: {correct_answer}, options: {q.get('options', [])}")
+        print(f"🔍 [SUBMIT] Question already answered: {was_answered}, previous correct: {previous_correct}")
         
         if question_type == 'mcq':
             options = q.get('options', [])
@@ -1503,6 +1510,16 @@ with gr.Blocks(title="Gnosis Tutor") as app:
         # Store user's selected answer in the question data for reference
         q['user_selected_answer'] = user_selected_idx if user_selected_idx is not None else selected
         q['is_correct'] = is_correct
+        q['is_answered'] = True  # Mark as answered
+        
+        # Calculate new score - only increment if question wasn't already answered
+        if was_answered:
+            # Question was already answered, adjust score based on new answer
+            # Remove previous answer's contribution
+            if previous_correct:
+                score["correct"] = max(0, score["correct"] - 1)
+            score["total"] = max(0, score["total"] - 1)
+            print(f"🔍 [SUBMIT] Question was already answered, adjusting score: {score}")
         
         new_score = {
             "correct": score["correct"] + (1 if is_correct else 0),
@@ -1562,15 +1579,19 @@ with gr.Blocks(title="Gnosis Tutor") as app:
         # Store explanation in user_state to be picked up by chat
         user_state["last_quiz_explanation"] = chat_message
         
+        # Update user_state with the modified quiz_data
+        user_state["current_quiz"] = quiz_data
+        
         # Return exactly 7 values matching the outputs
+        # Use gr.update() without value for quiz_data_state to avoid triggering change events
         return (
             gr.update(visible=True, value=feedback),  # quiz_feedback - MAKE SURE IT'S VISIBLE
             gr.update(visible=True, value=explanation),  # quiz_explanation - MAKE SURE IT'S VISIBLE
-            gr.update(visible=False),  # quiz_submit_btn (hide after submission)
+            gr.update(visible=False, interactive=False),  # quiz_submit_btn (hide after submission)
             gr.update(visible=idx < len(quiz_data) - 1),  # quiz_next_btn
             gr.update(value=idx),  # current_question_idx
             gr.update(value=new_score),  # quiz_score_state
-            gr.update(value=quiz_data)  # quiz_data_state
+            gr.update()  # quiz_data_state - don't update to avoid infinite loops
         )
     
     def next_question(quiz_data, idx, score):
@@ -1665,7 +1686,7 @@ with gr.Blocks(title="Gnosis Tutor") as app:
                 gr.update(visible=False),
                 gr.update(value=0),
                 gr.update(value={"correct": 0, "total": 0}),
-                gr.update(value=[])
+                gr.update()  # Don't update quiz_data_state to avoid loops
             )
         try:
             result = submit_answer(selected, quiz_data, idx, score)
@@ -1682,7 +1703,7 @@ with gr.Blocks(title="Gnosis Tutor") as app:
                 gr.update(visible=False),
                 gr.update(value=idx),
                 gr.update(value=score),
-                gr.update(value=quiz_data)
+                gr.update()  # Don't update quiz_data_state to avoid loops
             )
     
     quiz_submit_btn.click(
@@ -2090,13 +2111,30 @@ if __name__ == "__main__":
     /* Quiz Block - Uses EXACT same styling as left sidebar (glass-tabs-container) */
     /* All quiz elements inherit from glass-tabs-container styling automatically */
     
-    /* Quiz feedback and explanation visibility */
+    /* Quiz feedback and explanation visibility - Force visibility when content exists */
     .quiz-feedback,
     .quiz-explanation {
         display: block !important;
         visibility: visible !important;
         opacity: 1 !important;
         margin: 1rem 0 !important;
+        z-index: 100 !important;
+        position: relative !important;
+    }
+    
+    /* Ensure feedback is visible even when Gradio tries to hide it */
+    .quiz-feedback[style*="display: none"],
+    .quiz-explanation[style*="display: none"] {
+        display: block !important;
+        visibility: visible !important;
+    }
+    
+    /* Make sure HTML content inside feedback is visible */
+    .quiz-feedback > div,
+    .quiz-explanation > div {
+        display: block !important;
+        visibility: visible !important;
+        opacity: 1 !important;
     }
     
     /* Chat Interface Glass - Enhanced & Fully Rounded */

data/preloaded_concepts.json

@@ -50,3 +50,5 @@
 
 
 
+
+

mcp_server.py

@@ -354,3 +354,5 @@ if __name__ == "__main__":
     mcp.run()
 
 
+
+