some fixes

app.py

@@ -99,30 +99,6 @@ function refresh() {
         window.location.href = url.href;
     }
 }
-
-// Handle "Show only failing models" toggle
-function setupFailingModelsFilter() {
-    // Wait for DOM to be ready
-    setTimeout(() => {
-        const checkbox = document.querySelector('.failing-models-toggle input[type="checkbox"]');
-        if (checkbox) {
-            checkbox.addEventListener('change', (e) => {
-                const showOnlyFailing = e.target.checked;
-                const passingModels = document.querySelectorAll('.model-button.no-failures');
-                
-                passingModels.forEach(btn => {
-                    if (showOnlyFailing) {
-                        btn.style.display = 'none';
-                    } else {
-                        btn.style.display = 'block';
-                    }
-                });
-            });
-        }
-    }, 500);
-}
-
-setupFailingModelsFilter();
 """
 
 # Create the Gradio interface with sidebar and dark theme
@@ -175,27 +151,47 @@ with gr.Blocks(title="Model Test Results Dashboard", css=load_css(), js=js_func)
                 model_buttons = []
                 model_choices = [model.lower() for model in Ci_results.available_models] if Ci_results.available_models else ["auto", "bert", "clip", "llama"]
                 
+                # Separate failing and passing models
+                failing_models = []
+                passing_models = []
+                
                 print(f"Creating {len(model_choices)} model buttons: {model_choices}")
 
                 for model_name in model_choices:
                     # Check if model has failures to determine styling
                     has_failures = model_has_failures(model_name)
-                    button_classes = ["model-button"]
                     if has_failures:
-                        button_classes.append("model-button-failed")
-                        button_classes.append("has-failures")
+                        failing_models.append(model_name)
                     else:
-                        button_classes.append("model-button-passing")
-                        button_classes.append("no-failures")
-                    
-                    btn = gr.Button(
-                        model_name,
-                        variant="secondary",
-                        size="sm",
-                        elem_classes=button_classes,
-                        elem_id=f"model-btn-{model_name}"
-                    )
-                    model_buttons.append(btn)
+                        passing_models.append(model_name)
+                
+                # Container for all models (visible by default)
+                with gr.Column(visible=True, elem_classes=["all-models-container"]) as all_models_container:
+                    for model_name in model_choices:
+                        has_failures = model_has_failures(model_name)
+                        button_classes = ["model-button"]
+                        if has_failures:
+                            button_classes.append("model-button-failed")
+                        
+                        btn = gr.Button(
+                            model_name,
+                            variant="secondary",
+                            size="sm",
+                            elem_classes=button_classes
+                        )
+                        model_buttons.append(btn)
+                
+                # Container for failing models only (hidden by default)
+                failing_buttons = []
+                with gr.Column(visible=False, elem_classes=["failing-models-container"]) as failing_models_container:
+                    for model_name in failing_models:
+                        btn = gr.Button(
+                            model_name,
+                            variant="secondary",
+                            size="sm",
+                            elem_classes=["model-button", "model-button-failed"]
+                        )
+                        failing_buttons.append(btn)
 
             # CI job links at bottom of sidebar
             ci_links_display = gr.Markdown("🔗 **CI Jobs:** *Loading...*", elem_classes=["sidebar-links"])
@@ -321,6 +317,22 @@ with gr.Blocks(title="Model Test Results Dashboard", css=load_css(), js=js_func)
                         elem_classes=["plot-container"]
                     )
 
+    # Failing models toggle functionality
+    def toggle_failing_models_filter(show_failing_only):
+        """Toggle between showing all models and only failing models."""
+        if show_failing_only:
+            # Show only failing models container
+            return gr.update(visible=False), gr.update(visible=True)
+        else:
+            # Show all models container
+            return gr.update(visible=True), gr.update(visible=False)
+    
+    show_only_failing.change(
+        fn=toggle_failing_models_filter,
+        inputs=[show_only_failing],
+        outputs=[all_models_container, failing_models_container]
+    )
+
     # Model toggle functionality
     def toggle_model_list(current_visible):
         """Toggle the visibility of the model list."""
@@ -631,6 +643,7 @@ with gr.Blocks(title="Model Test Results Dashboard", css=load_css(), js=js_func)
                 gr.update(visible=False),    # time_series_detail_view
             selected_model, True)            # selected_model_state, in_model_view_state
 
+    # Wire up all model buttons
     for i, btn in enumerate(model_buttons):
         model_name = model_choices[i]
         btn.click(
@@ -654,6 +667,31 @@ with gr.Blocks(title="Model Test Results Dashboard", css=load_css(), js=js_func)
                 in_model_view_state,
             ],
         )
+    
+    # Wire up failing model buttons (same functionality)
+    for i, btn in enumerate(failing_buttons):
+        model_name = failing_models[i]
+        btn.click(
+            fn=lambda history_mode, m=model_name: handle_model_click(m, history_mode),
+            inputs=[history_view_button],
+            outputs=[
+                plot_output,
+                amd_failed_tests_output,
+                nvidia_failed_tests_output,
+                current_view,
+                historical_view,
+                summary_display,
+                detail_view,
+                time_series_failure_rates,
+                time_series_amd_tests,
+                time_series_nvidia_tests,
+                time_series_amd_model_plot,
+                time_series_nvidia_model_plot,
+                time_series_detail_view,
+                selected_model_state,
+                in_model_view_state,
+            ],
+        )
 
     # Auto-update CI links when the interface loads
     demo.load(

styles.css

@@ -200,7 +200,7 @@ div[data-testid="column"]:has(.sidebar) {
     border: 1px solid #333 !important;
     border-radius: 6px !important;
     padding: 10px 12px !important;
-    margin: 8px 0px 15px 0px !important;
+    margin: 8px 0px 12px 0px !important;
     transition: all 0.3s ease !important;
 }
 
@@ -217,6 +217,8 @@ div[data-testid="column"]:has(.sidebar) {
     text-transform: uppercase !important;
     letter-spacing: 0.5px !important;
     cursor: pointer !important;
+    display: flex !important;
+    align-items: center !important;
 }
 
 .failing-models-toggle input[type="checkbox"] {
@@ -224,6 +226,7 @@ div[data-testid="column"]:has(.sidebar) {
     cursor: pointer !important;
     width: 18px !important;
     height: 18px !important;
+    margin-right: 8px !important;
 }
 
 .failing-models-toggle input[type="checkbox"]:checked {