Update app.py

app.py

@@ -34,6 +34,7 @@ logger.info("="*80)
 PEXELS_API_KEY = os.environ.get("PEXELS_API_KEY")
 if not PEXELS_API_KEY:
     logger.critical("PEXELS_API_KEY environment variable not found.")
+    # Uncomment to force fail if not set:
     # raise ValueError("Pexels API key not configured")
 
 # Model Initialization
@@ -618,7 +619,7 @@ def crear_video(prompt_type, input_text, musica_file=None):
         # 6. Handle background music
         logger.info("Processing audio...")
         
-        final_audio = audio_tts_original # Start with the original valid TTS audio
+        final_audio = audio_tts_original
 
         musica_audio_looped = None
 
@@ -649,7 +650,6 @@ def crear_video(prompt_type, input_text, musica_file=None):
 
 
                 if musica_audio_looped:
-                    # Use the looped music and the current audio_tts (which is the original)
                     composite_audio = CompositeAudioClip([
                         musica_audio_looped.volumex(0.2),
                         audio_tts_original.volumex(1.0)
@@ -659,12 +659,11 @@ def crear_video(prompt_type, input_text, musica_file=None):
                         logger.warning("Composite audio clip is invalid (None or zero duration). Using voice audio only.")
                         try: composite_audio.close()
                         except: pass
-                        # Components were likely closed by composite_audio.close() or will be in main finally
-                        final_audio = audio_tts_original # Fallback
+                        final_audio = audio_tts_original
                     else:
                          logger.info("Audio mix completed (voice + music).")
-                         final_audio = composite_audio # Use the valid composite audio
-                         musica_audio = musica_audio_looped # Assign for cleanup
+                         final_audio = composite_audio
+                         musica_audio = musica_audio_looped
 
             except Exception as e:
                 logger.warning(f"Error processing background music: {str(e)}", exc_info=True)
@@ -692,13 +691,13 @@ def crear_video(prompt_type, input_text, musica_file=None):
                  logger.warning(f"Error adjusting final audio duration: {str(e)}")
 
 
-        # Final check on video_final before writing
         video_final = video_base.set_audio(final_audio)
 
         if video_final is None or video_final.duration is None or video_final.duration <= 0:
              logger.critical("Final video clip (with audio) is invalid before writing (None or zero duration).")
              raise ValueError("Final video clip is invalid before writing.")
 
+
         output_filename = "final_video.mp4"
         output_path = os.path.join(temp_dir_intermediate, output_filename)
         logger.info(f"Writing final video to: {output_path}")
@@ -728,33 +727,60 @@ def crear_video(prompt_type, input_text, musica_file=None):
         logger.info("Starting cleanup of clips and intermediate temporary files...")
         
         for clip in source_clips:
-            try: clip.close()
-            except Exception as e: logger.warning(f"Error closing source video clip in finally: {str(e)}")
+            try:
+                clip.close()
+            except Exception as e:
+                logger.warning(f"Error closing source video clip in finally: {str(e)}")
             
         for clip_segment in clips_to_concatenate:
-             try: clip_segment.close()
-             except Exception as e: logger.warning(f"Error closing video segment clip in finally: {str(e)}")
+            try:
+                clip_segment.close()
+            except Exception as e:
+                logger.warning(f"Error closing video segment clip in finally: {str(e)}")
 
-        try:
-            # Close audio clips: looped music, original music, then final audio (which might close its components)
-            if musica_audio is not None: try: musica_audio.close() except Exception as e: logger.warning(f"Error closing musica_audio in finally: {str(e)}")
-            if musica_audio_original is not None and musica_audio_original is not musica_audio: try: musica_audio_original.close() except Exception as e: logger.warning(f"Error closing musica_audio_original in finally: {str(e)}")
-            
-            # Close TTS clips: potentially modified/trimmed TTS, then original TTS
-            if audio_tts is not None and audio_tts is not audio_tts_original: try: audio_tts.close() except Exception as e: logger.warning(f"Error closing audio_tts (modified) in finally: {str(e)}")
-            if audio_tts_original is not None: try: audio_tts_original.close() except Exception as e: logger.warning(f"Error closing audio_tts_original in finally: {str(e)}")
-
-            # Close video clips: final video (should cascade), then video base if it wasn't the final
-            if video_final is not None:
-                try: video_final.close()
-                except Exception as e: logger.warning(f"Error closing video_final in finally: {str(e)}")
-            elif video_base is not None:
-                 try: video_base.close()
-                 except Exception as e: logger.warning(f"Error closing video_base in finally: {str(e)}")
+        # Close audio clips: looped music, original music, then final audio (which might close its components)
+        if musica_audio is not None:
+            try:
+                musica_audio.close()
+            except Exception as e:
+                logger.warning(f"Error closing musica_audio (processed) in finally: {str(e)}")
+        
+        if musica_audio_original is not None and musica_audio_original is not musica_audio:
+             try:
+                 musica_audio_original.close()
+             except Exception as e:
+                 logger.warning(f"Error closing musica_audio_original in finally: {str(e)}")
 
-        except Exception as e:
-            logger.warning(f"Error during final clip closing in finally: {str(e)}")
+        # Close TTS clips: potentially modified/trimmed TTS, then original TTS
+        # Note: audio_tts variable is only assigned audio_tts_original in this code, but keep structure for safety
+        if audio_tts is not None and audio_tts is not audio_tts_original:
+             try:
+                 audio_tts.close()
+             except Exception as e:
+                 logger.warning(f"Error closing audio_tts (processed) in finally: {str(e)}")
 
+        if audio_tts_original is not None:
+             try:
+                 audio_tts_original.close()
+             except Exception as e:
+                 logger.warning(f"Error closing audio_tts_original in finally: {str(e)}")
+
+
+        # Close video clips: final video (should cascade), then video base if it wasn't the final
+        if video_final is not None:
+            try:
+                video_final.close()
+            except Exception as e:
+                logger.warning(f"Error closing video_final in finally: {str(e)}")
+        # Note: video_base variable is reassigned to final_video_base. Close only if it exists and is different from video_final
+        elif video_base is not None and video_base is not video_final: # Check if video_base holds a different clip
+             try:
+                 video_base.close()
+             except Exception as e:
+                 logger.warning(f"Error closing video_base in finally: {str(e)}")
+
+
+        # Clean up intermediate files, but NOT the final video file
         if temp_dir_intermediate and os.path.exists(temp_dir_intermediate):
              final_output_in_temp = os.path.join(temp_dir_intermediate, "final_video.mp4")
              
@@ -775,14 +801,12 @@ def run_app(prompt_type, prompt_ia, prompt_manual, musica_file):
     
     input_text = prompt_ia if prompt_type == "Generar Guion con IA" else prompt_manual
     
-    # Initialize outputs to None and default status
     output_video = None
     output_file = None
     status_msg = gr.update(value="⏳ Procesando...", interactive=False)
 
     if not input_text or not input_text.strip():
         logger.warning("Empty input text.")
-        # Return None for video and file, update status
         return None, None, gr.update(value="⚠️ Por favor, ingresa texto para el guion o el tema.", interactive=False)
 
     logger.info(f"Input Type: {prompt_type}")
@@ -799,25 +823,21 @@ def run_app(prompt_type, prompt_ia, prompt_manual, musica_file):
         if video_path and os.path.exists(video_path):
             logger.info(f"crear_video returned path: {video_path}")
             logger.info(f"Size of returned video file: {os.path.getsize(video_path)} bytes")
-            output_video = video_path # Set video component value
-            output_file = video_path   # Set file component value for download
+            output_video = video_path
+            output_file = video_path
             status_msg = gr.update(value="✅ Video generado exitosamente.", interactive=False)
         else:
             logger.error(f"crear_video did not return a valid path or file does not exist: {video_path}")
-            # Leave video and file outputs as None
             status_msg = gr.update(value="❌ Error: La generación del video falló o el archivo no se creó correctamente.", interactive=False)
 
     except ValueError as ve:
         logger.warning(f"Validation error during video creation: {str(ve)}")
-        # Leave video and file outputs as None
         status_msg = gr.update(value=f"⚠️ Error de validación: {str(ve)}", interactive=False)
     except Exception as e:
         logger.critical(f"Critical error during video creation: {str(e)}", exc_info=True)
-        # Leave video and file outputs as None
         status_msg = gr.update(value=f"❌ Error inesperado: {str(e)}", interactive=False)
     finally:
         logger.info("End of run_app handler.")
-        # Return all three outputs
         return output_video, output_file, status_msg
 
 
@@ -867,15 +887,14 @@ with gr.Blocks(title="Generador de Videos con IA", theme=gr.themes.Soft(), css="
         
         with gr.Column():
             video_output = gr.Video(
-                label="Generated Video Preview", # Changed label
+                label="Generated Video Preview",
                 interactive=False,
                 height=400
             )
-            # Add the File component for download
             file_output = gr.File(
                 label="Download Video",
-                interactive=False, # Not interactive for user upload
-                visible=False # Hide initially
+                interactive=False,
+                visible=False
             )
             status_output = gr.Textbox(
                 label="Status", 
@@ -892,22 +911,18 @@ with gr.Blocks(title="Generador de Videos con IA", theme=gr.themes.Soft(), css="
         outputs=[ia_guion_column, manual_guion_column]
     )
 
-    # Modify the click event to return 3 outputs
     generate_btn.click(
-        # Action 1: Reset outputs and set status to processing
         lambda: (None, None, gr.update(value="⏳ Procesando... Esto puede tomar 2-5 minutos.", interactive=False)),
         outputs=[video_output, file_output, status_output],
         queue=True,
     ).then(
-        # Action 2: Call the main processing function
         run_app,
         inputs=[prompt_type, prompt_ia, prompt_manual, musica_input],
-        outputs=[video_output, file_output, status_output] # Match the 3 outputs
+        outputs=[video_output, file_output, status_output]
     ).then(
-        # Action 3: Make the download link visible if a file was returned
-        lambda video_path: gr.update(visible=video_path is not None), # Check if video_output has a value
-        inputs=[video_output], # Use video_output as input to check if generation was successful
-        outputs=[file_output] # Update visibility of file_output
+        lambda video_path, file_path: gr.update(visible=video_path is not None or file_path is not None), # Show download if either video or file path is returned
+        inputs=[video_output, file_output],
+        outputs=[file_output]
     )