Update app.py

app.py

@@ -2,14 +2,12 @@ import gradio as gr
 from analyze_email_main import analyze
 from weasyprint import HTML
 import tempfile
-import os
 
 def html_to_pdf(html_content):
     """Convert HTML string to a temporary PDF file and return its path."""
-    tmp_pdf = tempfile.NamedTemporaryFile(delete=False, suffix=".pdf")
-    tmp_pdf.close()  # Close before writing
-    HTML(string=html_content).write_pdf(tmp_pdf.name)
-    return tmp_pdf.name
+    with tempfile.NamedTemporaryFile(delete=False, suffix=".pdf") as tmp_pdf:
+        HTML(string=html_content).write_pdf(tmp_pdf.name)
+        return tmp_pdf.name
 
 def analyze_email(file_path, export_pdf=False):
     if file_path is None:
@@ -17,7 +15,7 @@ def analyze_email(file_path, export_pdf=False):
 
     results = analyze(file_path)
 
-    # Basic verdict info
+    # Extract basic verdict info
     attack_score = results[0]
     attack_type = results[1]
     verdict = results[2]
@@ -27,26 +25,28 @@ def analyze_email(file_path, export_pdf=False):
         score_val = 100
 
     # Verdict color
-    verdict_color = (
-        "#e74c3c" if "Malicious" in verdict else
-        "#e67e22" if "Suspicious" in verdict else
-        "#f1c40f" if "Spam" in verdict else
-        "#2ecc71"
-    )
+    verdict_color = "#2ecc71"  # default green
+    if "Malicious" in verdict:
+        verdict_color = "#e74c3c"
+    elif "Suspicious" in verdict:
+        verdict_color = "#e67e22"
+    elif "Spam" in verdict:
+        verdict_color = "#f1c40f"
 
     # Extract sections
     try:
         tags_index = results.index("---- Attack Analysis Tags ----")
         findings_index = results.index("---- Detailed Findings ----")
         body_index = results.index("---- Highlighted Body ----")
-        tags = results[tags_index + 1 : findings_index]
-        findings = results[findings_index + 1 : body_index]
-        highlighted_body = results[body_index + 1 :]
     except ValueError:
         html = "<pre>" + "\n".join(results) + "</pre>"
         return html, None
 
-    # HTML Report
+    tags = results[tags_index + 1 : findings_index]
+    findings = results[findings_index + 1 : body_index]
+    highlighted_body = results[body_index + 1 :]
+
+    # HTML Report with collapsible sections
     html = f"""
     <div style='font-family: Arial, sans-serif; padding: 20px; max-width: 800px; margin:auto;'>
       <h2 style="color:#2c3e50;">📧 Email Security Report</h2>
@@ -60,21 +60,32 @@ def analyze_email(file_path, export_pdf=False):
       <p><b>Final Verdict:</b> <span style="background:{verdict_color}; color:white; padding:4px 10px; border-radius:6px;">
         {verdict.replace('Final Verdict:', '').strip()}
       </span></p>
-      <h3>🔖 Attack Analysis Tags</h3>
-      <ul>{''.join(f'<li>{tag}</li>' for tag in tags)}</ul>
-      <h3>🕵️ Detailed Findings</h3>
-      <ul>{''.join(f'<li>{finding}</li>' for finding in findings)}</ul>
-      <h3>📩 Highlighted Email Body</h3>
-      <div style='border:1px solid #ccc; padding:15px; background:#fdfdfd; border-radius:8px;'>
-        {"<br>".join(highlighted_body)}
-      </div>
+      <details style="margin-top:15px;">
+        <summary>🔖 Attack Analysis Tags ({len(tags)})</summary>
+        <ul>
+          {''.join(f'<li>{tag}</li>' for tag in tags)}
+        </ul>
+      </details>
+      <details style="margin-top:15px;">
+        <summary>🕵️ Detailed Findings ({len(findings)})</summary>
+        <ul>
+          {''.join(f'<li>{finding}</li>' for finding in findings)}
+        </ul>
+      </details>
+      <details style="margin-top:15px;">
+        <summary>📩 Highlighted Email Body</summary>
+        <div style='border:1px solid #ccc; padding:15px; background:#fdfdfd; border-radius:8px;'>
+          {"<br>".join(highlighted_body)}
+        </div>
+      </details>
     </div>
     """
 
-    pdf_path = html_to_pdf(html) if export_pdf else None
+    pdf_path = None
+    if export_pdf:
+        pdf_path = html_to_pdf(html)
 
-    # Ensure Gradio doesn't break when PDF is not generated
-    return html, pdf_path if pdf_path and os.path.exists(pdf_path) else None
+    return html, pdf_path
 
 # Gradio Interface
 demo = gr.Interface(
@@ -88,10 +99,8 @@ demo = gr.Interface(
         gr.File(label="Download PDF Report")
     ],
     title="📧 Email Security Analyzer",
-    description=(
-        "Upload an .eml file to detect phishing, spam, or malicious emails. "
-        "Check 'Export PDF Report' to download a professional PDF report."
-    )
+    description="Upload an .eml file to detect phishing, spam, or malicious emails. "
+                "Check 'Export PDF Report' to download a professional PDF report."
 )
 
 if __name__ == "__main__":